Let users configure the LEDC output_pin as open-drain #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continue to default to push-pull.
BryanKadzban
changed the title
Contributor
Author
|
Those two should fix the workflows. Yes, this is intentionally an API change for the channel's Config. |
Contributor
Author
|
Hopefully that last commit sorts this out for real. Not sure why the upstream rustc is OK without the semicolon but the xtensa fork errors, but either way, the fix should work for both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally the ledc module would let users pre-configure the OutputPin that it drives, instead of forcing the output to always be push-pull. Then internal pullups, pulldowns, etc. might all be possible as well. But for my current project, driving an output low and letting it float when high, is all I really need. (Driving it high would still result in current through the LEDs connected to it, as their voltage would be higher than the chip's 3.3V supply.)