Update to [email protected] and [email protected]
#487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
approved these changes
Apr 21, 2023
Contributor
bjoernQ
left a comment
bjoernQ
left a comment
There was a problem hiding this comment.
LGTM
As you said there is not much to test but the code changes look good to me
i404788
pushed a commit
to i404788/esp-hal
that referenced
this pull request
Jul 22, 2023
…pha.2` (esp-rs#487) * Update `embedded-hal-1` and `embedded-hal-nb` dependencies to latest versions * Update the `Delay` and `I2c` trait implementations * Update the `SpiDevice` trait, implement `SpiDeviceRead` and `SpiDeviceWrite`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in the new
embedded-halrelease affectDelay,I2C, andSPI.The changes for
DelayandI2Cwere trivial.SPIwas a bit more interesting;SpiDevicehas changed, and there are additionally nowSpiDeviceReadandSpiDeviceWritetraits.We don't really have any examples exercising the alpha
DelayorI2Ctraits, so wasn't really able to test that. Assuming the previous implementation works, though, there's no reason to believe these changes should make any difference.I was able to test
SpiDeviceat least using thespi_eh1_device_loopbackexample, which succeeded, however the new traits have not been directly tested. With that said, their implementations are the same asSpiDevice, so no reason to expect them not to work.My knowledge is admittedly lacking when it comes to the
core::cellmodule, so I wasn't really sure why I had to dereference thebusvariable, but that made the compiler happy at least. If there's better syntax for this lemme know.Closes #468