Implement embedded_hal_nb::serial::* traits for UsbSerialJtag
#498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebraham
changed the title
embedded-hal-nb::serial::* traits for UsbSerialJtagembedded_hal_nb::serial::* traits for UsbSerialJtag
i404788
pushed a commit
to i404788/esp-hal
that referenced
this pull request
Jul 22, 2023
…p-rs#498) * Implement `embedded-hal-nb` serial traits for `UsbSerialJtag` * Fix warnings in `usb_serial_jtag` examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small PR, these traits were never implemented for this peripheral (and they're essentially the same as the previous traits, so easy enough to add).
Also fixed some warnings I accidentally introduced in a previous PR.