ESP32: Initial PSRAM Support #506
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic PSRAM support for ESP32.
It also adds
logas a dependency since it turned out to be useful during implementation.We should probably add more logging where it makes sense (e.g. when an interrupt got triggered and we call the default handler - that's usually a thing when adding a new chip to esp-wifi). Also, it might make sense to configure log levels via compile time filters in esp-template ( https://docs.rs/log/0.4.17/log/#compile-time-filters ) in future
(Closes #445)
I changed my mind regarding how PSRAM gets initialized. Previously I introduced a
common_initwhere this was done but that caused problems and I think having the explicit init better matches the overall way of doing things with esp-hal.The code here is more or less a straight port of the code found in esp-idf reduced to the bare minimum. This will definitely not support each and every board / module ever produced - however adding code for more exotic versions only makes sense when having access to such hardware.