Initial support for PCNT in ESP32-H2 #551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebraham
changed the title
bjoernQ
approved these changes
May 19, 2023
Contributor
bjoernQ
left a comment
bjoernQ
left a comment
There was a problem hiding this comment.
LGTM
Was able to test this with a rotary encoder - works fine
SergioGasquez
added a commit
to SergioGasquez/esp-hal
that referenced
this pull request
Jun 9, 2023
* feat: ✨ Enable PCNT peripheral * feat: ✨ Rename PCNT GPIOs * feat: ✨ Add pcnt_encoder example * build: ⬆️ Update esp-pacs revision * docs: 📝 Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial support for PCNT and the
pcnt_encoderexample.I couldn't fully test the example as I don't have a rotatory encoder, but I was able to see some prints by shorting the pins. If someone could properly test it, it would be appreciated!