Set ADC attenuation for the correct ADC instance #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
approved these changes
May 22, 2023
Member
MabezDev
left a comment
MabezDev
left a comment
There was a problem hiding this comment.
Ouch, that's a nasty one. I even had to take a double glace to actually see the change 😅. Nice spot!
JurajSadel
approved these changes
May 22, 2023
Contributor
JurajSadel
left a comment
JurajSadel
left a comment
There was a problem hiding this comment.
LGTM, thank you for spotting it!
SergioGasquez
pushed a commit
to SergioGasquez/esp-hal
that referenced
this pull request
Jun 9, 2023
* Set ADC attenuation for the correct ADC instance * Add to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a very well hidden bug where both ADCs configure the attenuation values of ADC1.
cc #550 #326