Add a fn to poll a DMA transfer #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement it by forwarding to the DMA channel's existing is_done mehod. Add the implementation to both SPI and I2S DMA transfer structs.
Only in the SPI case, but the I2S case has the same API so this should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's already a tree of functions to do this starting with a TxPrivate or RxPrivate ... but those aren't supposed to be used outside the HAL. Add a fn to the transaction traits instead, and implement it using the support in RxPrivate and TxPrivate.
Must
errorsorwarnings.cargo fmtwas run.CHANGELOG.mdin the proper section.Unsure if examples work - I have no access to the hardware at the moment.
There are a few existing warnings, but this PR does not add any more.
Nice to have