H2: Add initial LEDC support with example #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JurajSadel
force-pushed
the
feature/esp32h2-ledc
branch
2 times, most recently
from
386b50a to
00bb13a
Compare
JurajSadel
force-pushed
the
feature/esp32h2-ledc
branch
from
00bb13a to
ffec2dd
Compare
Contributor
Author
|
I think this is ready for review, I played a bit with the ESP-IDF example and they are also using bit 0 as clk src |
Member
SergioGasquez
left a comment
SergioGasquez
left a comment
There was a problem hiding this comment.
Changes LGTM but cant verify the example on real HW!
jessebraham
approved these changes
May 29, 2023
Member
jessebraham
left a comment
jessebraham
left a comment
There was a problem hiding this comment.
LGTM (as far as I can tell, at least), thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: esp-rs/esp-pacs#122