Skip to content

Initial support for ASSIST_DEBUG in ESP32-H2 #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jessebraham merged 8 commits into from
May 30, 2023
Merged

Initial support for ASSIST_DEBUG in ESP32-H2 #566

jessebraham merged 8 commits into from
May 30, 2023

Conversation

@SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented May 30, 2023 •
edited
Loading

Adds initial support for ASSIST_DEBUG and the debug_assist example.

Tested the example and here is the output:

  • enable_sp_monitor
I (200) boot: Disabling RNG early entropy source...
W (204) bootloader_random: bootloader_random_disable() has not been implemented yet
Iteration 0
Iteration 1
Iteration 2
Iteration 3
Iteration 4
Iteration 5
Iteration 6
Iteration 7
Iteration 8
Iteration 9

DEBUG_ASSIST interrupt
SP MONITOR TRIGGERED
PC = 0x4200b10a
0x4200b10a - core::ptr::write_volatile
    at /home/sergio/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ptr/mod.rs:1618
  • enable_region0_monitor
I (200) boot: Disabling RNG early entropy source...
W (204) bootloader_random: bootloader_random_disable() has not been implemented yet
Iteration 0
Iteration 1
Iteration 2
Iteration 3
Iteration 4
Iteration 5
Iteration 6

DEBUG_ASSIST interrupt
REGION0 MONITOR TRIGGERED
PC = 0x42015d8a
0x42015d8a - core::ptr::mut_ptr::<impl *mut T>::is_null::runtime_impl
   at /home/sergio/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ptr/mut_ptr.rs:35
  • enable_region1_monitor
I (200) boot: Disabling RNG early entropy source...
W (204) bootloader_random: bootloader_random_disable() has not been implemented yet
Iteration 0
Iteration 1
Iteration 2
Iteration 3
Iteration 4
Iteration 5
Iteration 6

DEBUG_ASSIST interrupt
REGION1 MONITOR TRIGGERED
PC = 0x42015d8c
0x42015d8c - core::ptr::mut_ptr::<impl *mut T>::is_null::runtime_impl
   at /home/sergio/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ptr/mut_ptr.rs:35

@SergioGasquez SergioGasquez marked this pull request as ready for review May 30, 2023 15:18
jessebraham
jessebraham requested changes May 30, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just one tiny little change I'd like to see, LGTM otherwise (will test it out in the meantime to confirm)

jessebraham
jessebraham approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessebraham jessebraham merged commit faf60b6 into esp-rs:main May 30, 2023
MabezDev pushed a commit to MabezDev/esp-hal that referenced this pull request Jun 1, 2023
@SergioGasquez @MabezDev
Initial support for ASSIST_DEBUG in ESP32-H2 (esp-rs#566)
295ff5c 
* feat: ✨ Add debug_assist example

* feat: ✨ Enable peripherals

* docs: 📝 Add RAM comments

* feat: ⚡️ Update debug_assist example

* docs: 📝 Update changelog

* build: 📌 Update esp-pacs rev for h2

* style: 🎨 Move assist_debug_region* and assist_debug_sp* to peripherals defined by developers
SergioGasquez added a commit to SergioGasquez/esp-hal that referenced this pull request Jun 9, 2023
@SergioGasquez
Initial support for ASSIST_DEBUG in ESP32-H2 (esp-rs#566)
d9ecccc 
* feat: ✨ Add debug_assist example

* feat: ✨ Enable peripherals

* docs: 📝 Add RAM comments

* feat: ⚡️ Update debug_assist example

* docs: 📝 Update changelog

* build: 📌 Update esp-pacs rev for h2

* style: 🎨 Move assist_debug_region* and assist_debug_sp* to peripherals defined by developers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SergioGasquez @jessebraham