Add embassy_serial and embassy_wait examples for ESP32-H2
#569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebraham
force-pushed
the
feature/esp32h2-examples
branch
from
b39b456 to
ea4758b
Compare
JurajSadel
approved these changes
May 31, 2023
Contributor
JurajSadel
left a comment
JurajSadel
left a comment
There was a problem hiding this comment.
LGTM, both examples work fine for me.
Just a note not related to this PR, maybe we should add an embassy-time-systick and/or embassy-time-timg0 as a required feature in embassy examples.
Member
Author
|
Agreed, but see: #563 |
Member
SergioGasquez
left a comment
SergioGasquez
left a comment
There was a problem hiding this comment.
Changes LGTM but there are timing differences between using embassy-time-timg0 and embassy-time-systick feature for the embassy_serial example
MabezDev
pushed a commit
to MabezDev/esp-hal
that referenced
this pull request
Jun 1, 2023
…#569) * Add `embassy_{serial,wait}` examples for ESP32-H2 * Update the CHANGELOG
SergioGasquez
pushed a commit
to SergioGasquez/esp-hal
that referenced
this pull request
Jun 9, 2023
…#569) * Add `embassy_{serial,wait}` examples for ESP32-H2 * Update the CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.