Skip to content

Async GPIO multibank fix #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jessebraham merged 2 commits into from
Jun 1, 2023
Merged

Async GPIO multibank fix #572

jessebraham merged 2 commits into from
Jun 1, 2023

Conversation

@MabezDev
Copy link
Member

@MabezDev MabezDev commented Jun 1, 2023 •
edited
Loading

  • Removes dead code from the default impl of the BankAccess trait
  • Adds one new function to the async module to control the interrupt enable for any pin

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

Closes #571

@MabezDev MabezDev force-pushed the async/gpio-int-enable-multibank branch from 4176008 to d2e5e22 Compare June 1, 2023 13:00
MabezDev added 2 commits June 1, 2023 14:03
@MabezDev
Async GPIO multibank fix
748ecad 
- Removes dead code from the default impl of the BankAccess trait
- Adds one new function to the async module to control the interrupt
  enable for any pin
@MabezDev
Add changelog entry
be36e2c
@MabezDev MabezDev force-pushed the async/gpio-int-enable-multibank branch from d2e5e22 to be36e2c Compare June 1, 2023 13:03
@MabezDev MabezDev marked this pull request as ready for review June 1, 2023 13:43
bjoernQ
bjoernQ approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessebraham jessebraham merged commit 34740c7 into esp-rs:main Jun 1, 2023
SergioGasquez pushed a commit to SergioGasquez/esp-hal that referenced this pull request Jun 9, 2023
@MabezDev @SergioGasquez
Async GPIO multibank fix (esp-rs#572)
28d5434 
* Async GPIO multibank fix

- Removes dead code from the default impl of the BankAccess trait
- Adds one new function to the async module to control the interrupt
  enable for any pin

* Add changelog entry
SergioGasquez pushed a commit to SergioGasquez/esp-hal that referenced this pull request Jun 15, 2023
@MabezDev @SergioGasquez
Async GPIO multibank fix (esp-rs#572)
d56c65e 
* Async GPIO multibank fix

- Removes dead code from the default impl of the BankAccess trait
- Adds one new function to the async module to control the interrupt
  enable for any pin

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jessebraham jessebraham jessebraham approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GPIO interrupt handler disables the incorrect interrupt when the request comes from a Bank1 pin

3 participants

@MabezDev @jessebraham @bjoernQ