Add CRC functionality from ESP ROM #587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code compiles withoutPre-existing warnings from unrelated codeerrorsorwarnings.cargo fmtwas run.CHANGELOG.mdin the proper section.Nice to have
ESP ROM includes hard-coded, referentially transparent CRC functions via simple table lookups. Kilobytes of program space can be saved using them. A compile-time
#[cfg]attribute is internally used to automatically link against the ROM function or to a fallback implementation if not available.Currently, all chips implement all functions except ESP32-S2 which omits the
*_be()variants. On this chip those functions will be compiled instead.I tested the example code on a real ESP32-C3, and simulated the ESP32-S2 on Wokwi to test the fallback implementation. All examples compile.