H2: Add I2S support
#597
Merged
H2: Add I2S support
#597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebraham
approved these changes
Jun 19, 2023
Member
jessebraham
left a comment
jessebraham
left a comment
There was a problem hiding this comment.
This LGTM, thanks for tackling it! Don't have any I2S peripherals handy though, @bjoernQ would you be able to confirm this is working as expected whenever you get a chance please?
bjoernQ
approved these changes
Jun 19, 2023
Contributor
bjoernQ
left a comment
bjoernQ
left a comment
There was a problem hiding this comment.
LGTM
tested on hardware - worked fine for me
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
i2s_readandi2s_soundexamples.Adds
PLL_96MHzclock sourceAdds
I2Srelated clock constants for all chips.