Pin log crate to v0.4.18 #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
force-pushed
the
pin-log
branch
2 times, most recently
from
835ceab to
2f74819
Compare
This is temporary measure, as the problem cannot be solved cleanly right now. The issue is that the msrv check uses the stable compiler, which uses a stable cargo. With a stable cargo, the unstable `build-std` option is not respected within `.cargo/config.toml`. This means `core` is never rebuilt with the atomic cfg flags so we get this error when building log version 0.4.19. The 0.4.19 release uses the atomic cfg flags instead of a custom build script, so by switching back to 0.4.188888888 we can avoid this issue... for now at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is temporary measure, as the problem cannot be solved cleanly right now.
The issue is that the msrv check uses the stable compiler, which uses a stable cargo. With a stable cargo, the unstable
build-stdoption is not respected within.cargo/config.toml. This meanscoreis never rebuilt with the atomic cfg flags so we get this error when building log version 0.4.19. The 0.4.19 release uses the atomic cfg flags instead of a custom build script, so by switching back to 0.4.18 we can avoid this issue... for now at least.