Skip to content

Conversation

@jordanhalase
Copy link
Contributor

Must

  • The code compiles without errors or warnings. Docs-only change
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section. N/A unless told it's needed
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

I noticed cargo-fmt was mangling the docs.

I also noticed a few typos.

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jessebraham jessebraham merged commit 144169f into esp-rs:main Jun 22, 2023
@jordanhalase jordanhalase deleted the crc_docs branch June 22, 2023 23:52
MabezDev pushed a commit that referenced this pull request Jul 12, 2023
* Fix rom::crc docs

* Make ROM mod.rs consistent with esp-idf-hal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants