Avoid overlapping .data / .rwtext #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
approved these changes
Jun 23, 2023
Member
MabezDev
left a comment
MabezDev
left a comment
There was a problem hiding this comment.
Another nice find! Thanks for taking care of this! LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a case where
.dataand.rwtextcan overlap if.rwtext's length is not aligned (which might happen because not all instructions are 32bit)See esp-rs/esp-mbedtls#8
What happened there
0x4037dacfis 0x1d0x4037dad0is 0xf00x4037dad0and3fc8dad0map to the same location in SRAM - so we end up with an illegal instruction at 0x4037dacf