Add MD5 functionality from ESP ROM #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
approved these changes
Jun 26, 2023
Contributor
bjoernQ
left a comment
bjoernQ
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your contribution
MabezDev
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Add ROM MD5 definitions in linker and devices * Add initial MD5 support * Implement traits and add comments to MD5 module * Add MD5 example to ESP32-C3 * Test MD5 context on the quick brown fox * Implemenr From<Context> for Digest * Add MD5 to the rest of the examples * Add docs for MD5 * Remove #[repr(transparent)] from md5::Digest * Update CHANGELOG.md
playfulFence
pushed a commit
to playfulFence/esp-hal
that referenced
this pull request
Sep 26, 2023
* Add ROM MD5 definitions in linker and devices * Add initial MD5 support * Implement traits and add comments to MD5 module * Add MD5 example to ESP32-C3 * Test MD5 context on the quick brown fox * Implemenr From<Context> for Digest * Add MD5 to the rest of the examples * Add docs for MD5 * Remove #[repr(transparent)] from md5::Digest * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errorsorwarnings.cargo fmtwas run.CHANGELOG.mdin the proper section.Nice to have
All the ESP32 chips include an MD5 implementation in their ROM. This PR adds linkage to them and a safe, consistent API over them that mimics the MD5 crate and can act as a drop-in replacement.
I checked the updated examples on a physical ESP32-C3 and simulated ESP32-S2. It should work on the others as the linker locations were pulled from ESP-IDF.
MD5 is needed in order to start reading the ESP32 partition tables.