DMA descriptor count fixes #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioGasquez
pushed a commit
to SergioGasquez/esp-hal
that referenced
this pull request
Jun 28, 2023
MabezDev
pushed a commit
that referenced
this pull request
Jul 12, 2023
playfulFence
pushed a commit
to playfulFence/esp-hal
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the equation to calculate the required number of DMA descriptors. The driver requires descriptors in sets of 3, one set for each 4092 byte chunk. The former equation (
(BUFFERSIZE / 4092) * 3) evaluates to 0 for transfers of size 0..4092, 3 for 4092..8184, etc, which is basically 3 less than required for cases whereBUFFERSIZE % 4092 != 0.