Skip to content

Add WithDmaSpi3 to prelude on espd32s3 #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bjoernQ merged 2 commits into from
Jun 27, 2023
Merged

Add WithDmaSpi3 to prelude on espd32s3 #623

bjoernQ merged 2 commits into from
Jun 27, 2023

Conversation

@bugadani
Copy link
Contributor

@bugadani bugadani commented Jun 26, 2023

Follow-up for #507

@bugadani bugadani marked this pull request as draft June 26, 2023 16:35
@bugadani
Copy link
Contributor Author

bugadani commented Jun 26, 2023 •
edited
Loading

Hold on I want to modify an example to test this.

I ended up copying an example so that we can test this PR. It's a bit redundant, but hopefully not too confusing :)

@bugadani bugadani marked this pull request as ready for review June 26, 2023 16:39
bjoernQ
bjoernQ approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this

@bjoernQ bjoernQ merged commit 73fb717 into esp-rs:main Jun 27, 2023
@bugadani bugadani deleted the dma branch June 27, 2023 06:54
@bugadani bugadani mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bugadani @bjoernQ