Skip to content

Conversation

@jessebraham
Copy link
Member

  • Derive the Clone and Copy trait to the Rng driver
    • There is no reason this driver can't be cloned/copied, and some packages provide interfaces which consume the driver (ie. esp-wifi), so this allows continued use of Rng after Wi-Fi initialization if required
  • Fully document the peripheral driver

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice job on the docs, they look great!

@jessebraham jessebraham merged commit 58651f0 into esp-rs:main Jul 12, 2023
@jessebraham jessebraham deleted the feature/clone-copy-rng branch July 12, 2023 14:16
playfulFence pushed a commit to playfulFence/esp-hal that referenced this pull request Sep 26, 2023
* Derive the `Clone` and `Copy` traits for the `Rng` driver

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants