Remove the allow-opt-level-z feature from esp32c3-hal
#654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
approved these changes
Jul 14, 2023
Contributor
bjoernQ
left a comment
bjoernQ
left a comment
There was a problem hiding this comment.
LGTM - should we double check it's really fixed (via #196 (comment) that should be easy) before merging?
MabezDev
approved these changes
Jul 14, 2023
Member
MabezDev
left a comment
MabezDev
left a comment
There was a problem hiding this comment.
I tested that mim repro and it worked 🎉. LGTM!
playfulFence
pushed a commit
to playfulFence/esp-hal
that referenced
this pull request
Sep 26, 2023
* Remove the `allow-opt-level-z` feature from `esp32c3-hal` * Update CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this comment from @MabezDev, this feature should no longer be required. I tested the
timer_interruptexample, which was identified as problematic as this opt-level, and it worked just fine for me withopt-level = "z". More testing would be appreciated, however.