Make in-progress DMA transfers potentially fallible #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think there is some missing esp-hal-common code from the commits? :D |
Contributor
Author
🤦♂️ yes I forgot to commit most of the code 🤦♂️ |
8 tasks
playfulFence
pushed a commit
to playfulFence/esp-hal
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change to the DMA transfer's
wait(and for I2Swait_receive) functions to make them potentially fallible.It also adds checking for DMA descriptor errors as described in #491. Probably there might be more conditions to check but at least this changes the API in a way that can be added later.
For the async API (which we only have for SPI currently) it's already fallible - so no API change there.
Closes #491