Fix GPIO interrupt status not being cleared #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @MabezDev because of the |
bugadani
changed the title
Member
|
Oh wow, I'm actually dumb 🤦. How did I not think about the previous loop clearing all the bits in Regarding the split, could we do that in a separate PR? I'd like to see the performance difference once the cztz/czlz codegen improvements have been merged. |
Contributor
Author
Sure thing, we can do whatever :) Any opinions about the bit clearing change? |
Member
Looks good to me :) |
bugadani
force-pushed
the
ctlz
branch
2 times, most recently
from
ee4320d to
d4f3215
Compare
bugadani
changed the title
This was referenced Jul 22, 2023
|
@MabezDev Spoke too soon. It still doesn't work properly. |
bugadani
added a commit
to bugadani/esp-hal
that referenced
this pull request
Jul 24, 2023
* Fix clearing interrupt status * Use simpler way to clear bits * Add note about xtensa * Add to changelog
playfulFence
pushed a commit
to playfulFence/esp-hal
that referenced
this pull request
Sep 26, 2023
* Fix clearing interrupt status * Use simpler way to clear bits * Add note about xtensa * Add to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errorsorwarnings.cargo fmtwas run.CHANGELOG.mdin the proper section.Nice to have
This PR fixes an issue where
write_interrupt_status_clearwas always called with0as its argument, because the processing loop cleared the status bits. We also clear the bits by subtracting them instead of creating a mask first to and with - hopefully this optimizes better, too.