-
Notifications
You must be signed in to change notification settings - Fork 367
Add FlashSafeDma wrapper for eh traits which ensure correct DMA transfers from flash
#678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I like this approach much better than the other PR |
Thanks for the feedback! I'll look into fleshing out this approach. One thing I could use some help with is what to call this thing; I plucked |
|
Edit: maaaaaaybe some users could get confused and think it can also receive into flash (i.e. disambiguating into |
FlashSafeDma wrapper for eh traits which ensure correct DMA transfers from flash
I've kept it as |
jessebraham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in reviewing this, the notification must have gotten buried in my inbox because I missed it at some point 😅 I left one small suggestion but overall LGTM, thanks for this!
3c29fb1 to
fbf2db5
Compare
fbf2db5 to
5a1e4b4
Compare
5a1e4b4 to
d6f9d87
Compare
…nsfers from flash (esp-rs#678)
An alternative solution to #674, using a wrapper type instead of adding the checks to the current dma operations. This is only implemented for Spi traits at the moment, as that's the only peripheral we have dma support for and e-h traits.
Benefits to this approach:
Negatives to this approach:
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errorsorwarnings.cargo fmtwas run.CHANGELOG.mdin the proper section.Nice to have