Skip to content

Switch to micros instead of millis in set_periodic #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jessebraham merged 2 commits into from
Jul 31, 2023
Merged

Switch to micros instead of millis in set_periodic #686

jessebraham merged 2 commits into from
Jul 31, 2023

Conversation

@MabezDev
Copy link
Member

@MabezDev MabezDev commented Jul 25, 2023 •
edited
Loading

This gives more fine-grain control to allow higher frequencies.

Closes #685

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

@MabezDev MabezDev force-pushed the fine-grained-periodic branch from b279847 to 74822f7 Compare July 25, 2023 12:20
@MabezDev MabezDev marked this pull request as ready for review July 25, 2023 12:20
@MabezDev MabezDev mentioned this pull request Jul 25, 2023
Closed
bugadani
bugadani reviewed Jul 25, 2023
View reviewed changes
@MabezDev MabezDev force-pushed the fine-grained-periodic branch from 74822f7 to 058c9ed Compare July 26, 2023 09:29
@MabezDev MabezDev requested a review from jessebraham July 27, 2023 22:09
jessebraham
jessebraham approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham merged commit 18e8030 into esp-rs:main Jul 31, 2023
playfulFence pushed a commit to playfulFence/esp-hal that referenced this pull request Sep 26, 2023
@MabezDev @playfulFence
Switch to micros instead of millis in set_periodic (esp-rs#686)
88e9c24 
* Switch to micros instead of millis

* Add changelog entry
@bugadani bugadani mentioned this pull request Oct 25, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bugadani bugadani bugadani left review comments

@jessebraham jessebraham jessebraham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Periodic interrupts every 100ns

3 participants

@MabezDev @bugadani @jessebraham