Pin and RTCPin improvements #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2023
Contributor
Author
|
Eh, unless I messed up my trial, there is only a 1kB code size difference, so probably not worth the faff. |
MabezDev
approved these changes
Jul 28, 2023
Member
MabezDev
left a comment
MabezDev
left a comment
There was a problem hiding this comment.
Given that we weren't using the resultant &mut Self for chaining anywhere, I think this is a perfectly fine change.
playfulFence
pushed a commit
to playfulFence/esp-hal
that referenced
this pull request
Sep 26, 2023
* Make Pin a supertrait * Make Pin object-safe * Add to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTCPinnow extends PinPinis now object-safeThis change allows, for example, reading a pin's pin_number when one only has a
&dyn RTCPin.