Update esp-hal-smartled to use the new rmt driver, remove old pulse_control driver
#694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
approved these changes
Jul 27, 2023
Member
MabezDev
left a comment
MabezDev
left a comment
There was a problem hiding this comment.
LGTM! I tested on all the devkits I had and it works a treat, thanks!
This was referenced Jul 27, 2023
playfulFence
pushed a commit
to playfulFence/esp-hal
that referenced
this pull request
Sep 26, 2023
…lse_control` driver (esp-rs#694) * Remove the old `pulse_control` driver * Update `esp-hal-smartled` to use the new `rmt` driver instead * Update the `hello_rgb` example for each chip * Update CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
esp-hal-smartledpackage to use the newrmtdriver instead ofpulse_controlpulse_controldriver entirelyhello_rgbexamples to use the newrmtdriver instead ofpulse_controlI didn't test on every chip, but I tried a couple random devkits and they both worked, so I assume it's fine.
Closes #688