Skip to content

S3 sleep: Clean up register access #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MabezDev merged 1 commit into from
Aug 1, 2023
Merged

S3 sleep: Clean up register access #696

MabezDev merged 1 commit into from
Aug 1, 2023

Conversation

@bugadani
Copy link
Contributor

@bugadani bugadani commented Jul 27, 2023 •
edited
Loading

This PR cleans up #660 as it turns out that SYSCON is available as pac::APB_CTRL, and also BB, SPI0 and SPI1 exist.

@bugadani bugadani marked this pull request as ready for review July 27, 2023 18:40
@bugadani bugadani changed the title Reimplement SYSCON register access S3 sleep: Reimplement SYSCON register access Jul 27, 2023
@bugadani bugadani marked this pull request as draft July 27, 2023 18:45
@bugadani bugadani changed the title S3 sleep: Reimplement SYSCON register access S3 sleep: Clean up register access Jul 27, 2023
@bugadani bugadani marked this pull request as ready for review July 27, 2023 18:51
@bugadani bugadani force-pushed the sleep branch 3 times, most recently from a7c2d28 to e6071b0 Compare July 28, 2023 10:58
MabezDev
MabezDev approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MabezDev MabezDev merged commit 822497b into esp-rs:main Aug 1, 2023
@bugadani bugadani deleted the sleep branch August 1, 2023 14:32
playfulFence pushed a commit to playfulFence/esp-hal that referenced this pull request Sep 26, 2023
@bugadani @playfulFence
Clean up register access (esp-rs#696)
8b7ac7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MabezDev MabezDev MabezDev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bugadani @MabezDev