Update to 1.0.0-rc.1 version of embedded-hal-* crates
#747
Conversation
| embedded-hal-nb = { version = "=1.0.0-alpha.3", optional = true } | ||
| embedded-hal-1 = { version = "=1.0.0-rc.1", optional = true, package = "embedded-hal" } | ||
| embedded-hal-nb = { version = "=1.0.0-rc.1", optional = true } | ||
| embedded-io = "0.5.0" |
There was a problem hiding this comment.
shouldn't this be optional and only get included if we target eh1 / async?
There was a problem hiding this comment.
The embedded_io trait implementations are not feature gated currently. Should they be? I didn't see any reason to, they're not really following the 1.0.0-xxx release cycle of the other packages. But I can change this if there's a reason to.
There was a problem hiding this comment.
well we pull an unused dependency this way 🤷♂️
There was a problem hiding this comment.
embedded-hal and embedded-dma should both be optional too then, right? I'm not really sure where we're drawing the line here. I'm not against feature gating it, I'd just like to come up with actual criteria for this I guess.
There was a problem hiding this comment.
I think code implementing embedded-hal and embedded-dma is not feature gated.
But embedded-hal-1 is and it's optional because of that.
|
Thanks for the reviews! @MabezDev I believe I have addressed your comments now. |
* Update a bunch of dependencies * Implement `embedded-io` and `embedded-io-async` traits for USB Serial JTAG * Implement `embedded-io` and `embedded-io-async` traits for UART * Fix `embassy_serial` examples * Update CHANGELOG * Address review comments
3 participants
embedded-hal,embedded-hal-async, andembedded-hal-nbto1.0.0-rc.1embedded-ioandembedded-io-asyncpackagesReadandWritetraits fromembedded-io{-async}for UART and USB Serial JTAGNeeded to use some git dependencies for now, but we'll get that all sorted prior to the next release.
I've done some very quick testing on a couple chips and things seem to look okay so far, but I will continue to test more thoroughly.
Did a bit of cleanup in the drivers as well, so sorry for the noise there.
Closes #727
Closes #735