-
Notifications
You must be signed in to change notification settings - Fork 367
Add support for splitting esp32 uart into TX and RX #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Do anyone know why the Instance type is not propagated to UartFuture in the new() constructor ? It is well propagated from Uart to UartRx and UartTx in their new_inner() contructor. Is it because UartFuture lives in a sub mod Asynch ? |
|
Sorry, missed this completely! To fix the current compilation errors, you just need to specify that the |
|
why do my cargo fmt is not the same as the one from CI ? $ cargo fmt --version
rustfmt 1.6.0-stable (5680fa1 2023-08-23) |
MabezDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good functionality wise, but could we improve the example? What about sending the read bytes over a channel to the write to be written back out? As it stands the example isn't very interactive. We can also drop the AT command stuff for this example.
|
Another alternative would be to instead of adding a new example, change the current embassy_serial one to use split by default. |
OK I will do that. Sorry I have very few time for this now... |
* Keeps existing API for uart, but wraps it in Tx and Rx sub-types * Adds split() method similar to embassy-rs nRF/stm32/rp for getting indepdendent TX and RX parts * Implements e-h traits for TX and RX types * Add esp32s3 example
|
i did mess up my repo while rebasing, and this close the PR. sorry |
MabezDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Georges760! LGTM!
* Add support for splitting esp32 uart into TX and RX * Keeps existing API for uart, but wraps it in Tx and Rx sub-types * Adds split() method similar to embassy-rs nRF/stm32/rp for getting indepdendent TX and RX parts * Implements e-h traits for TX and RX types * Add esp32s3 example * finish implementing * rebase examples * declare new examples * fix fmt * rebase on 0.12.0 * fix fmt * fix fmt * merge embassy_serial_split example with embassy_serial * fix changelog * fix changelog
Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errorsorwarnings.cargo fmtwas run.CHANGELOG.mdin the proper section.Nice to have