Skip to content

Conversation

@bugadani
Copy link
Contributor

@bugadani bugadani commented Aug 26, 2023

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

Updates the build-in executors to use the newest embassy-executor crate. This change means that calling a pender no longer goes through a function pointer - but it needs a runtime branch to figure out which interrupt to fire.

I renamed a macro parameter as it wasn't very well named, so that increases the noise level a bit, but hopefully will reduce future confusion potential.

This PR does not change user-facing APIs. Hopefully, I've feature-guarded the __pender function correctly, too, in case someone wants to use their own executors. Unfortunately, it is not possible to mix one of ours (thread or interrupt) with a custom executor. This tradeoff was acceptable to the embassy project, so I hope this shortfall won't cause much problems here, either.

Unfortunately, due to some transitive sadness, we have to use the git dependency until a new embassy-time is released. Thanks Jesse for the embassy-time release!

@bugadani bugadani force-pushed the newexecutor branch 8 times, most recently from c1b03c2 to 8cc1b2c Compare August 28, 2023 18:18
@bugadani bugadani changed the title [WIP] Update to embassy-executor 0.3.0 Update to embassy-executor 0.3.0 Aug 28, 2023
@bugadani
Copy link
Contributor Author

bugadani commented Aug 28, 2023

My test cases, that I actually tried:

  • ESP32/embassy_multicore example
  • ESP32/embassy_multicore_interrupt example
  • my own S3 project

All 3 test cases seem to work well so hopefully I didn't mess anything important up. I've fixed the labels of the CI jobs I copy-paste-error'ed last time.

@bugadani bugadani marked this pull request as ready for review August 28, 2023 19:07
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this!

@jessebraham jessebraham merged commit 92a2cc7 into esp-rs:main Aug 29, 2023
@bugadani bugadani deleted the newexecutor branch August 29, 2023 17:39
playfulFence pushed a commit to playfulFence/esp-hal that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants