Update to embassy-executor 0.3.0 #756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errorsorwarnings.cargo fmtwas run.CHANGELOG.mdin the proper section.Nice to have
Updates the build-in executors to use the newest embassy-executor crate. This change means that calling a pender no longer goes through a function pointer - but it needs a runtime branch to figure out which interrupt to fire.
I renamed a macro parameter as it wasn't very well named, so that increases the noise level a bit, but hopefully will reduce future confusion potential.
This PR does not change user-facing APIs. Hopefully, I've feature-guarded the
__penderfunction correctly, too, in case someone wants to use their own executors. Unfortunately, it is not possible to mix one of ours (thread or interrupt) with a custom executor. This tradeoff was acceptable to the embassy project, so I hope this shortfall won't cause much problems here, either.Unfortunately, due to some transitive sadness, we have to use the git dependency until a new embassy-time is released.Thanks Jesse for the embassy-time release!