PARL_IO RX for ESP32-C6 / H2 #760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
force-pushed
the
feature/parl_io_rx
branch
from
d80d9d0 to
f4aee24
Compare
2 tasks
jessebraham
approved these changes
Aug 29, 2023
Member
jessebraham
left a comment
jessebraham
left a comment
There was a problem hiding this comment.
Thanks for this! This is a fairly complex peripheral so there's a lot to take in here, but seems reasonable enough to me.
I left one small comment, however if you don't feel like addressing it just feel free to merge this as-is.
| esp-backtrace = { version = "0.7.0", features = ["esp32h2", "panic-handler", "exception-handler", "print-uart"] } | ||
| esp-hal-smartled = { version = "0.4.0", features = ["esp32h2"], path = "../esp-hal-smartled" } | ||
| esp-println = { version = "0.5.0", features = ["esp32h2"] } | ||
| esp-println = { version = "0.5.0", features = ["esp32h2", "log"] } |
Member
There was a problem hiding this comment.
Not a big deal, but I see the log feature is enabled and the logger is initialized in the example, however no logging seems to actually take place (println! is used).
I assume this was for debugging? The same is done for the ESP32-C6.
JurajSadel
approved these changes
Aug 29, 2023
Contributor
JurajSadel
left a comment
JurajSadel
left a comment
There was a problem hiding this comment.
LGTM, examples work fine for me.
playfulFence
pushed a commit
to playfulFence/esp-hal
that referenced
this pull request
Sep 26, 2023
* PARL_IO RX for ESP32-C6 / H2 * Add PARL_IO RX to README.md * Remove logger-init from PARL_IO_RX examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds RX functionality to the PARL_IO driver, follow-up on #733
The examples are quite basic but I also tested somewhat more complex scenarios. I haven't really understood the pulse-enable mode or it's not fully working - but it's implemented according to the TRM so we probably need to wait until ESP-IDF implements this to see if we have something wrong or if I just don't understand how it's supposed to work. Everything else however works as expected.
Closes #719