Skip to content

Add missing GPIO conversion #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bjoernQ merged 1 commit into from
Aug 30, 2023
Merged

Add missing GPIO conversion #764

bjoernQ merged 1 commit into from
Aug 30, 2023

Conversation

@bugadani
Copy link
Contributor

@bugadani bugadani commented Aug 30, 2023 •
edited
Loading

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

When I noticed that GPIOs implement From<Gpio<Unknown...> and decided to do some cleanup with it, I found that converting to analog pin mode wasn't implemented. This PR adds this implementation and also cleans up return values.

@bugadani bugadani mentioned this pull request Aug 30, 2023
Merged
@bugadani bugadani marked this pull request as ready for review August 30, 2023 03:55
bjoernQ
bjoernQ approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoernQ bjoernQ merged commit 32d1ea0 into esp-rs:main Aug 30, 2023
@bugadani bugadani deleted the analog branch August 30, 2023 07:18
playfulFence pushed a commit to playfulFence/esp-hal that referenced this pull request Sep 26, 2023
@bugadani @playfulFence
Add missing conversion (esp-rs#764)
263b569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bugadani @bjoernQ