Add defmt support, make log optional
#773
Conversation
bugadani
force-pushed
the
defmt
branch
3 times, most recently
from
c0b5cca to
bafc9a9
Compare
MabezDev
left a comment
MabezDev
left a comment
There was a problem hiding this comment.
There might be an easier way to do this (completely stolen from the embassy crates :D)
Copy this file into the project: https://github.com/MabezDev/embedded-fatfs/blob/master/src/fmt.rs
and ensure that its the first module defined in the crate: https://github.com/MabezDev/embedded-fatfs/blob/master/src/lib.rs#L67-L68 by doing this you don't have to import all the macros.
bugadani
force-pushed
the
defmt
branch
10 times, most recently
from
76dfe9d to
dbac001
Compare
bugadani
force-pushed
the
defmt
branch
11 times, most recently
from
4a6f506 to
aab19e3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
| - This corresponds to the date that the `1.65.0` release was branched from `master` | ||
| - `1.65.0` for Xtensa devices (**ESP32**, **ESP32-S2**, **ESP32-S3**) | ||
| - `1.67.0` for all `async` examples (`embassy_hello_world`, `embassy_wait`, etc.) | ||
| - latest `stable` when using the `defmt` feature |
There was a problem hiding this comment.
Would have liked to discuss this a bit first :/ Guess I just need to release as-is.
There was a problem hiding this comment.
Well, apart from my comment being a slight lie (pinned defmt means MSRV is 1.70 or so I believe), the feature is opt-in and probably shouldn't affect existing users who don't enable it. In case you want to rush out the release, I'm not opposed to reverting.
* Executor related touchups * Make log optional * Add defmt feature and derive on Debug structs * Test both log drivers * Update esp-println * Document defmt msrv
* Executor related touchups * Make log optional * Add defmt feature and derive on Debug structs * Test both log drivers * Update esp-println * Document defmt msrv
3 participants
Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errorsorwarnings.cargo fmtwas run.CHANGELOG.mdin the proper section.Nice to have
Logging isn't particularly widely used in the HAL, but maybe defmt support may change that :)
PR is blocked on a new esp-println release