Skip to content

Add defmt::Format (and more) to some types #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MabezDev merged 1 commit into from
Sep 14, 2023
Merged

Add defmt::Format (and more) to some types #786

MabezDev merged 1 commit into from
Sep 14, 2023

Conversation

@bugadani
Copy link
Contributor

@bugadani bugadani commented Sep 12, 2023 •
edited
Loading

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

I've added defmt::Format to most error types, some others that derive Debug and fixed a few typos.

@bugadani
Copy link
Contributor Author

bugadani commented Sep 12, 2023

error: package toml_edit v0.19.15 cannot be built because it requires rustc 1.66.0 or newer, while the currently active rustc version is 1.65.0-nightly

Lovely

@bugadani bugadani changed the title Add defmt::Format to error enums Add defmt::Format to some error enums and more Sep 12, 2023
@bjoernQ
Copy link
Contributor

bjoernQ commented Sep 13, 2023

CI should be green again now after a rebase

@bugadani bugadani changed the title Add defmt::Format to some error enums and more Add defmt::Format (and more) to some types Sep 13, 2023
MabezDev
MabezDev approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MabezDev MabezDev merged commit 976549f into esp-rs:main Sep 14, 2023
@bugadani bugadani deleted the fmt branch September 14, 2023 19:17
SergioGasquez pushed a commit to SergioGasquez/esp-hal that referenced this pull request Sep 22, 2023
@bugadani @SergioGasquez
Add defmt::Format to error enums (esp-rs#786)
63a7e7e
playfulFence pushed a commit to playfulFence/esp-hal that referenced this pull request Sep 26, 2023
@bugadani @playfulFence
Add defmt::Format to error enums (esp-rs#786)
a8f7774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MabezDev MabezDev MabezDev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bugadani @bjoernQ @MabezDev