Make ADC reads return u16s, not generic types #792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think I don't see an obvious disadvantage in changing it to |
jessebraham
approved these changes
Sep 22, 2023
Member
jessebraham
left a comment
jessebraham
left a comment
There was a problem hiding this comment.
Yeah, I think this is just a copy-paste relic from the past, makes sense to make this change IMO. LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ADC read functions all return a generic
From<u16>but I couldn't find a rationale for it: the read is always done first as au16, so why not just return that and allow the user to convert it if they want?This change allows for removing some type annotations.