Remove unused Pin methods, optimize GPIO interrupt handler #793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errorsorwarnings.cargo fmtwas run.CHANGELOG.mdin the proper section.Nice to have
This PR optimizes the GPIO interrupt handler for devices that have multiple GPIO banks:
RSRinstructions, 103RSRinstruction for a final count of 94Unfortunately it looks like
get_corecan't be optimized away by the compiler even if the read core ID isn't used, so I've removed the calls from the GPIO interrupt handler. If there is a way to make the compiler understand that RSR isn't supposed to be a volatile read, the log calls can be added back, but I don't consider this to be a big deal.There is still an unnecessary bounds check (and panic) present in the generated code, because the compiler doesn't understand (even if masked) that the Bank1 interrupt status does not have more bits than NUM_PINS-32.
There's also a 16-byte stack reduction but I don't really know why.