Skip to content

Conversation

@bugadani
Copy link
Contributor

@bugadani bugadani commented Sep 18, 2023

Found by https://matrix.to/#/!LdaNPfUfvefOLewEIM:matrix.org/$FUWqLqPUH-bfGxi0FnjqIz2FsLID0u1wyRVKhSg6tV8?via=matrix.org&via=tchncs.de&via=mozilla.org

Hi all, I've been digging into esp32c3 sleep, and I noticed something that I think is backwards in esp32s3 sleep: here we're setting ck8m_force_pu to be the same as self.int_8m_pd_en(), but idf seems to do the opposite. I won't make a PR as I have no way of testing which is correct, but just wanted to let y'all know...

@bjoernQ
Copy link
Contributor

bjoernQ commented Sep 18, 2023

Would you mind quoting the Matrix message? Following that link, Element tells me it will disconnect my session and do scary things ....

@bugadani
Copy link
Contributor Author

Right, element's share is how it is. Done.

The point of this PR to enable powerDOWN if the clock source is NOT forced on. The old implementation was a direct reverse of this, I believe.

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@bjoernQ bjoernQ merged commit 6d93668 into esp-rs:main Sep 18, 2023
@bugadani bugadani deleted the sleep branch September 18, 2023 10:45
SergioGasquez pushed a commit to SergioGasquez/esp-hal that referenced this pull request Sep 22, 2023
playfulFence pushed a commit to playfulFence/esp-hal that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants