esp-hal-common: uart/ESP32: fix get_rx_fifo_count() #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manio
force-pushed
the
fifo_counter_fix
branch
2 times, most recently
from
6d40f34 to
d8af234
Compare
jessebraham
approved these changes
Sep 20, 2023
manio
force-pushed
the
fifo_counter_fix
branch
from
d8af234 to
0910b14
Compare
Currently the `get_rx_fifo_count()` is using `fifo_cnt`, which is unreliable for ESP32, according to the errata: https://www.espressif.com/sites/default/files/documentation/esp32_errata_en.pdf section 3.17 This commit is fixing the code for the ESP32 according to the workaround example. Main discussion and my debugging results: esp-rs#765
manio
force-pushed
the
fifo_counter_fix
branch
from
0910b14 to
6a60051
Compare
Contributor
Author
|
Should be good now, I also rebased again to get rid of CHANGELOG conflict. |
JurajSadel
approved these changes
Sep 21, 2023
Contributor
JurajSadel
left a comment
JurajSadel
left a comment
There was a problem hiding this comment.
LGTM, thank you for your contribution.
Contributor
Author
|
Thanks! 😁 |
SergioGasquez
pushed a commit
to SergioGasquez/esp-hal
that referenced
this pull request
Sep 22, 2023
Currently the `get_rx_fifo_count()` is using `fifo_cnt`, which is unreliable for ESP32, according to the errata: https://www.espressif.com/sites/default/files/documentation/esp32_errata_en.pdf section 3.17 This commit is fixing the code for the ESP32 according to the workaround example. Main discussion and my debugging results: esp-rs#765
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
get_rx_fifo_count()is usingfifo_cnt, which is unreliable for ESP32, according to the errata:https://www.espressif.com/sites/default/files/documentation/esp32_errata_en.pdf section 3.17
This commit is fixing the code for the ESP32 according to the workaround example.
Main discussion and my debugging results:
#765