-
Notifications
You must be signed in to change notification settings - Fork 367
(G)DMA AES working mode support #821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Some bikeshedding but generally looks good |
|
Thank you for the review @bjoernQ! I addressed your comments. |
bjoernQ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks for working on this
MabezDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
jessebraham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this!
Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errorsorwarnings.cargo fmtwas run.CHANGELOG.mdin the proper section.Nice to have
This doesn't add support for ESP32 and ESP32S2. I will create a separate PR for these two chips. Also, I left a few
TODOs mostly for ESP32 and I will address them in the next PR. I will addasyncsupport next and after that, I will add DMA for ESP32 and S2.