Skip to content

Conversation

@JurajSadel
Copy link
Contributor

@JurajSadel JurajSadel commented Sep 27, 2023

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

This doesn't add support for ESP32 and ESP32S2. I will create a separate PR for these two chips. Also, I left a few TODOs mostly for ESP32 and I will address them in the next PR. I will add async support next and after that, I will add DMA for ESP32 and S2.

@JurajSadel JurajSadel requested a review from bjoernQ September 27, 2023 05:11
@bjoernQ
Copy link
Contributor

bjoernQ commented Sep 27, 2023

Some bikeshedding but generally looks good

@JurajSadel
Copy link
Contributor Author

Thank you for the review @bjoernQ! I addressed your comments.

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for working on this

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@jessebraham jessebraham merged commit ca4e1b3 into esp-rs:main Sep 27, 2023
@JurajSadel JurajSadel deleted the feature/AES-DMA branch April 10, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants