Make sure to use ESP32Reset - not Reset as entry #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
approved these changes
Sep 27, 2023
Member
MabezDev
left a comment
MabezDev
left a comment
There was a problem hiding this comment.
Really nice find!!! This can't have been easy to spot :D. The changes look good to me! If S3 direct boot is already broken then we can sort that in another PR.
This is already handled for the RISCV chips because it's done in assembly before we even get to Rust here.
Contributor
Author
|
Will create an issue for S3-direct-boot. Thanks for the quick review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Xtensa targets used
Resetas entry but they must useESP32Resetin order to set the SP.Without setting SP, stack-allocations might overwrite memory which is reserved for the ROM functions on ESP32
Seems like direct-boot on ESP32-S3 is broken - but it was broken before: at least I'm unable to flash and run
hello_worldusing direct-boot (it flashes 4MB to the chip and the app won't come up)