Unify the ESP32's and ESP32-C2's xtal frequency features #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think in most places we are using a dash |
Member
Author
There are a bunch of other features with underscores in their names too, so I'll fix all of these in a subsequent PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no real reason to make a distinction for each chip, so I've removed two of these features to simplify things. These features were then updated where required, and renamed in the HAL packages to be consistent (hopefully not many people are using these).
I've also done a bunch of grouping and re-organizing of features in the Cargo manifest, so apologies for the noise there, but it's a bit nicer now IMO.