Assimilate lp-hal-procmacros into esp-hal-procmacros
#845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
approved these changes
Oct 12, 2023
Contributor
bjoernQ
left a comment
bjoernQ
left a comment
There was a problem hiding this comment.
Good idea - especially with fine grained feature gates it shouldn't have any disadvantages
MabezDev
pushed a commit
to MabezDev/esp-hal
that referenced
this pull request
Oct 20, 2023
* Assimilate `lp-hal-procmacros` into `esp-hal-procmacros` * Update `CHANGELOG.md`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not personally see any reason to have separate packages for this, however I'm open to hear any arguments against this. The
esp-hal-procmacrocrate is not necessarily updated with each HAL release, so I'm not too worried about egregious version-bumping or anything. From my perspective, this is one less package to maintain and publish, which is a win.I've added
enum-dispatchandramfeatures just to make it easier to gate off functionality which is not always required, much in the same way we were doing withinterruptalready.