Skip to content

Conversation

@jessebraham
Copy link
Member

Just some small changes, cleaning things up a bit. Part of my prelude-simplification-yak-shaving adventure (more fun to come!).

  • Remove the analog modules from the chip-specific HAL packages
    • Not sure why these existed in the first place? Historical reasons? Regardless, not necessary
  • Merge the SarAdcExt and SensExt traits into a single AnalogExt trait
    • There was no reason for these to be different traits
  • A bit of clean up and simplification in the analog module

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MabezDev MabezDev merged commit 4238a63 into esp-rs:main Oct 19, 2023
@jessebraham jessebraham deleted the fixes/analog branch October 19, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants