Skip to content

Conversation

@eteq
Copy link
Contributor

@eteq eteq commented Dec 20, 2023

On an esp32c6 with idf 5.1.1 (devkitC, although I doubt that matters), I could not for the life of me get the uart example to work. Eventually I figured out that, at least in my particular setup, the default clock for the UART is the PLL_F80M clock... which must not have existed in earlier IDFs (or maybe it's particular to the esp32c6? Not sure, but it doesn't really matter).

This PR simply adds support in for the UART_SCLK_PLL_F80M clock source, since without this I couldn't get past a panic from creating the default uart config.

@eteq
Copy link
Contributor Author

eteq commented Dec 20, 2023

Well that's odd - this works locally for me, but the CI is failing. I suppose it must be the #[cfg(all(esp_idf_version_major = "4", esp_idf_soc_uart_support_pll_f80m_clk))] element, but why would that be failing on the 5.1 builds and the 4.x builds?

@ivmarkov
Copy link
Collaborator

@eteq Run cargo fmt on the PR.

eteq added a commit to eteq/esp-mitsubishi-heatpump that referenced this pull request Dec 29, 2023
@t-moe
Copy link

t-moe commented Jan 4, 2024

I run into the same problem today.

Simply invoking uart::config::Config::new() will panic on esp32c6 with esp_idf 5.1. This PR seems to fix that.

@ivmarkov ivmarkov merged commit 33eb2d1 into esp-rs:master Jan 10, 2024
@ivmarkov
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants