Skip to content

Conversation

@j-g00da
Copy link
Contributor

@j-g00da j-g00da commented Feb 22, 2025

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo fmt command to ensure that all changed code is formatted correctly.
  • I have used cargo clippy command to ensure that all changed code passes latest Clippy nightly lints.
  • My changes were added to the CHANGELOG.md in the proper section.

Pull Request Details 📖

Description

The docs for task::notification::Notifier methods were outdated:

  • referenced Monitor struct, that was renamed to Notification,
  • referenced a Drop trait, that is not implemented anymore,
  • described implementation details that are no longer accurate.

Testing

N/A

@ivmarkov
Copy link
Collaborator

Thanks!

@ivmarkov ivmarkov merged commit a387891 into esp-rs:master Feb 23, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants