Skip to content

Conversation

@j-g00da
Copy link
Contributor

@j-g00da j-g00da commented Mar 4, 2025

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo fmt command to ensure that all changed code is formatted correctly.
  • I have used cargo clippy command to ensure that all changed code passes latest Clippy nightly lints.
  • My changes were added to the CHANGELOG.md in the proper section.

Pull Request Details 📖

Description

ESP-IDF 5 deprecated ADC_ATTEN_DB_11 and introduced ADC_ATTEN_DB_12, I think we should reflect that.

Testing

@ivmarkov
Copy link
Collaborator

A tricky change for what is basically a rename of the flag. But - you took the effort, so many thanks! Merging.

(And sorry for reacting so late.)

@ivmarkov ivmarkov merged commit 6c3cc56 into esp-rs:master Mar 13, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants