Fix typo in debug_assist register name #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
reviewed
Aug 19, 2024
5 tasks
bugadani
reviewed
Aug 19, 2024
bugadani
approved these changes
Aug 19, 2024
Contributor
bugadani
left a comment
bugadani
left a comment
There was a problem hiding this comment.
Thank you, I think that's all :) Not sure what's the process here, if I can merge this PR or not, so here's my approval for now :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in esp-rs/esp-hal#1961, debug_assist has a typo in a register on C3, C6, and H2. This fixes it.
cc @bugadani