Skip to content

Change long form of save-image --ignore-app-descriptor #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SergioGasquez merged 5 commits into from
Dec 9, 2025
Merged

Change long form of save-image --ignore-app-descriptor #974

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
35fabf2
Change long form of save-image --ignore-app-descriptor
Nov 25, 2025
be22673
fix fmt
Nov 25, 2025
9c8dca2
Update changelog
Nov 25, 2025
73ecd94
support alias
Dec 5, 2025
e21df86
format
Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Change long form of save-image --ignore-app-descriptor
  • Loading branch information
Dane Slattery committed Nov 25, 2025
commit 35fabf278935aef78c59e33f8e65dbca97e16aee
12 changes: 3 additions & 9 deletions espflash/src/cli/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,8 @@ use crate::{
},
error::{Error, MissingPartition, MissingPartitionTable},
flasher::{
DeviceInfo,
FLASH_SECTOR_SIZE,
FlashData,
FlashFrequency,
FlashMode,
FlashSettings,
FlashSize,
Flasher,
DeviceInfo, FLASH_SECTOR_SIZE, FlashData, FlashFrequency, FlashMode, FlashSettings,
FlashSize, Flasher,
},
image_format::{ImageFormat, ImageFormatKind, Metadata, idf::IdfBootloaderFormat},
target::{Chip, ProgressCallbacks, XtalFrequency},
Expand Down Expand Up @@ -259,7 +253,7 @@ pub struct ImageArgs {
#[arg(long, value_name = "MMU_PAGE_SIZE", value_parser = parse_u32)]
pub mmu_page_size: Option<u32>,
/// Skip checking whether the app descriptor is present in the image.
#[arg(long = "ignore_app_descriptor", default_value_t = true, action = clap::ArgAction::SetFalse)]
#[arg(long = "ignore-app-descriptor", default_value_t = true, action = clap::ArgAction::SetFalse)]
pub check_app_descriptor: bool,
}

Expand Down
Loading