Skip to content

Update I2S base frequency and frequency dividers to real ones #4031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
earlephilhower merged 10 commits into from
Jan 20, 2018
Merged

Update I2S base frequency and frequency dividers to real ones #4031

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
33a3112
Fix I2S base frequency
Crypter Dec 27, 2017
d1496a4
Merge pull request #1 from Crypter/hotfix/i2s_frequency
Crypter Dec 27, 2017
f335b28
Update frequency dividers for I2S
Crypter Dec 27, 2017
b07cc34
Merge branch 'master' into master
earlephilhower Jan 15, 2018
a380742
Merge branch 'master' into master
Crypter Jan 17, 2018
941e68e
fixed i2s_set_rate, added i2s_get_real_rate() and i2s_set_dividers
Jan 17, 2018
b56bc49
Minimise float calculations
Crypter Jan 18, 2018
6df60c4
Merge branch 'master' into master
Crypter Jan 18, 2018
f5d676a
Merge branch 'master' into master
earlephilhower Jan 20, 2018
f67cff8
Merge branch 'master' into master
earlephilhower Jan 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minimise float calculations 
Less is more
  • Loading branch information
@Crypter
Crypter authored Jan 18, 2018
commit b56bc495f3afe76639ef91a0803fbcbe93aba8b5
5 changes: 3 additions & 2 deletions cores/esp8266/core_esp8266_i2s.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,9 @@ void ICACHE_FLASH_ATTR i2s_set_rate(uint32_t rate){ //Rate in HZ
uint8_t scd_div_best=1;
for (uint8_t i=1; i<64; i++){
for (uint8_t j=i; j<64; j++){
if (fabs(((float)scaled_base_freq/i/j) - rate) < delta_best){
delta_best = fabs(((float)scaled_base_freq/i/j) - rate);
float new_delta = fabs(((float)scaled_base_freq/i/j) - rate);
if (new_delta < delta_best){
delta_best = new_delta;
sbd_div_best = i;
scd_div_best = j;
}
Expand Down